Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes AWSSQSQUEUE synthesis rules #1823

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jsubirat
Copy link
Contributor

Relevant information

The AWSSQSQUEUE entity definition included a rule that verified that the telemetry data point was coming from an eventType that starts with Log (to be able to support data partitions such as Log_MyDataPartition).

Nevertheless, logs originated from CloudTrail (this is where SQS logs come from) also include an eventType attribute (with value AwsApiCall). Because the eventType attribute is a reserved keyword by NRDB, this attribute is removed after the entity synthesis step in the Logs pipeline. However, the entity synthesis step still observes it with eventType: AwsApiCall.

This PR modifies the existing synthesis rules to not rely on the eventType attributes at all. Instead, it verifies that eventSource is sqs.amazonaws.com (this is the value set by CloudTrail to events originated from SQS) and that eventName is present. The Logging Pipeline will be the one including aws.sqs.QueueName and optionally entityId, so if these are present it is basically as saying "if the logs came from the Logging Pipeline".

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

@apoloa apoloa merged commit 9a59734 into newrelic:main Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants